Andreas Boll
2018-10-10 15:05:27 UTC
Andreas Boll pushed to branch debian-unstable at X Strike Force / lib / mesa
Commits:
ad478400 by Dylan Baker at 2018-09-07T17:10:13Z
docs/relnotes: Add sha256 sums for mesa 18.1.8
- - - - -
a985f18e by Marek Olšák at 2018-09-07T17:16:55Z
st/mesa: help fix stencil border color for GL_DEPTH_STENCIL textures
GL_STENCIL_INDEX uses GL_INTENSITY for the border color, which is nicer
to hardware that doesn't read the stencil border value from the X channel.
This fixes a bunch of dEQP tests on Vega & Raven.
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 725e8ad5590749ca2fa4bd89e1e8007fd20b114e)
- - - - -
2620eb8e by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: Add additional 18.2 patch
- - - - -
37fd6269 by Gert Wollny at 2018-09-07T17:16:55Z
winsys/virgl: correct resource and handle allocation (v2)
Fixes crash with
piglit/bin/map_buffer_range-invalidate CopyBufferSubData \
increment-offset -auto -fbo
* Resize the resource storage already when the count is equal to the
allocated size, fixes:
Invalid write of size 8
at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629)
by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd
at 0x4C31B25: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567)
* Also resize the space allocated for the handles, fixes:
Invalid write of size 4
at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631)
by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd
at 0x4C2FB0F: malloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so)
by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572)
Fixes: 4b15b5e803e ("virgl: resize resource bo allocation if we need to.")
v2: - Use REALLOC macro and avoid memory leak when re-allocation fails
- add Fixes tag (both Emil Velikov)
- reorder commit message
Signed-off-by: Gert Wollny <***@collabora.com>
(cherry picked from commit 9b0e8d87233691c1f025002f1da89ed3f8f69583)
- - - - -
527813b2 by Dylan Baker at 2018-09-07T17:16:55Z
meson: Print a message about why a libdrm version was selected
We require a single version of libdrm for all of our libdrm
dependencies (core and driver), but the way this is structured can make
the error message less than helpful, as one driver might be the one
setting the libdrm requirement, while another might be the one that
generates the version failure.
This adds a simple message to the output announcing which libdrm module
set the version, which might be more helpful.
v2: - Use message suggested by Eric Engstrom
Fixes: c445b1d56f47922206de55e557444aadb62e11f6
("meson: Use the same version for all libdrm checks")
Reviewed-by: Eric Engestrom <***@intel.com>
(cherry picked from commit d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7)
- - - - -
06579faa by Mathias Fröhlich at 2018-09-07T17:16:55Z
tnl: Fix green gun regression in xonotic.
Fix an other regression of
mesa: Make gl_vertex_array contain pointers to first order VAO members.
The regression showed up with drivers using the tnl module and
was reproducible using xonotic-glx -benchmark demos/the-big-keybench.dem.
Fixes: 64d2a204805
mesa: Make gl_vertex_array contain pointers to first order VAO members.
Tested-by: Ville Syrjälä <***@linux.intel.com>
Reviewed-by: Ian Romanick <***@intel.com>
Signed-off-by: Mathias Fröhlich <***@web.de>
(cherry picked from commit a6232b69321b465e9733a4b207088d923b75e714)
Conflicts resolved by Dylan
Conflicts:
src/mesa/tnl/t_split_copy.c
- - - - -
67cfeb16 by Timothy Arceri at 2018-09-07T17:16:55Z
glsl: fixer lexer for unreachable defines
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define itself is so
this then gets recognised as #if.
Until 28a3731e3f this didn't happen because we ended up in
<HASH>{NONSPACE} where BEGIN INITIAL was called stopping the
problem from happening.
This change makes sure we never call RETURN_TOKEN_NEVER_SKIP for
if/else/endif when processing a define.
Cc: Ian Romanick <***@freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
- - - - -
6f43390d by Jason Ekstrand at 2018-09-07T17:16:55Z
anv/pipeline: Only consider double elements which actually exist
The brw_vs_prog_data::double_inputs_read field comes directly from
shader_info::double_inputs which may contain inputs which are not
actually read. Instead of using it directly, AND it with inputs_read
which is only things which are read. Otherwise, we may end up
subtracting too many elements when computing elem_count.
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103241
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit 7b26741806c521279a1b83f2eae40a277d806626)
- - - - -
b5e03dec by Sergii Romantsov at 2018-09-07T17:16:55Z
intel: compiler option msse2 and mstackrealign
Seems in case of 32-bit library, usage of msse2 makes
some stack corruption or incorrect instructions.
Usage with mstackrealign fixes that case.
v2: Fixed meson.
v3: Definition of c_sse2_args moved on the top (L.Landwerlin).
Added mstackrealign for Android's mks where msee4.1 is used.
v4: Added for Vulkan also.
v5: Commit message correction.
CC: <mesa-***@lists.freedesktop.org>
Fixes: 6b05c080f202 (i965: Compile with -msse3)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779
Signed-off-by: Sergii Romantsov <***@globallogic.com>
Reviewed-by: Dylan Baker <***@pnwbakers.com>
Reviewed-by: Emil Velikov <***@collabora.com>
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit d709f127927cb0ad40d5bf4eaec33c3c27f7738a)
- - - - -
b14c2b46 by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: add another 18.2 patch
- - - - -
019ff6b4 by Andrii Simiklit at 2018-09-07T17:16:55Z
apple/glx/log: added missing va_end() after va_copy()
Each invocation of va_copy() must be matched by a
corresponding invocation of va_end()
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 51691f0767f6 "darwin: Use ASL for logging"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 267ed29288db478a47d180bd1370a4df60ddb3ef)
- - - - -
4a44ff8b by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: don't use the same 'va_list' instance twice
The first usage of the 'va_list' instance could change it.
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 570cacba7af165175ad40820c5e663db5b1c5066)
- - - - -
a17aed45 by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: don't ignore NULL returned from 'malloc'
We should exit from the function 'util_vasprintf'
with error code -1 for case where 'malloc'
returns NULL
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 65cfe698b0f4ba412198d212c14481a60c1b8389)
- - - - -
ea7df5b7 by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: add missing va_end() after va_copy()
MSDN:
"va_end must be called on each argument list that's initialized
with va_start or va_copy before the function returns."
Reviewed-by: Eric Engestrom <***@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810
Fixes: c6267ebd6c8a "gallium/util: Stop bundling our snprintf implementation."
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 2930b76cfe1e13e84ac0d88f9c6d709a5a8d4c18)
- - - - -
99ecc5fc by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: Add patches that don't apply cleanly and are for developer tools
- - - - -
08e3909c by Jason Ekstrand at 2018-09-10T17:12:04Z
i965: Workaround the gen9 hw astc5x5 sampler bug
gen9 hardware has a bug in the sampler cache that can cause GPU hangs
whenever an texture with aux compression enabled is in the sampler cache
together with an ASTC5x5 texture. Because we can't control what the
client binds at any given time, we have two options: resolve the CCS or
decompresss the ASTC. Doing a CCS or HiZ resolve is far less drastic
and will likely have a smaller performance impact.
Cc: mesa-***@lists.freedesktop.org
Reviewed-by: Kristian H. Kristensen <***@google.com>
Tested-by: Tapani Pälli <***@intel.com>
Reviewed-by: Topi Pohjolainen <***@intel.com>
(cherry picked from commit f9e630e23dfa3de815026a08e7e767e2ed90da0b)
- - - - -
9f08ea8c by Jason Ekstrand at 2018-09-10T17:12:09Z
anv: Re-emit vertex buffers when the pipeline changes
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance
data step rate, and pitch come from the pipeline.
Cc: mesa-***@lists.freedesktop.org
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit c643c5e18d7c647afc6dcc450183b81a62a40998)
- - - - -
3bfed07f by Jason Ekstrand at 2018-09-10T17:12:20Z
anv: Disable the vertex cache when tessellating on SKL GT4
I have no idea if I'm correct about what's going wrong or if this is the
correct fix. However, in my multiple weeks of banging my head on this
hang, a VUE reference counting bug seems to match all the symptoms and
it definitely fixes the hang.
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107280
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit b08b4b2b25b201df2d667cf70d7f99475e5c7aec)
- - - - -
05985a64 by Jason Ekstrand at 2018-09-10T17:13:27Z
anv: Clamp scissors to the framebuffer boundary
The Vulkan 1.1.81 spec says:
"It is legal for offset.x + extent.width or offset.y + extent.height
to exceed the dimensions of the framebuffer - the scissor test still
applies as defined above. Rasterization does not produce fragments
outside of the framebuffer, so such fragments never have the scissor
test performed on them."
Elsewhere, the Vulkan 1.1.81 spec says:
"The application must ensure (using scissor if necessary) that all
rendering is contained within the render area, otherwise the pixels
outside of the render area become undefined and shader side effects
may occur for fragments outside the render area. The render area
must be contained within the framebuffer dimensions."
Unfortunately, there's some room for interpretation here as to what the
consequences are of having the render area set to exactly the
framebuffer dimensions and having a scissor that is larger than the
framebuffer. Given that GL and other APIs provide automatic clipping to
the framebuffer, it makes sense that applications would assume that
Vulkan does this as well. It costs us very little to play it safe and
just clamp client-provided scissors to the framebuffer dimensions.
Fortunately, the user is required to provide us with at least one
scissor so we don't need to handle the case where they don't.
Fixes: fb2a5ceb3264 "anv: Emit DRAWING_RECTANGLE once at driver..."
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit 465e5a868cd58ca7c4ff7476e98231ffd4f3d2bf)
- - - - -
4670daa1 by Dave Airlie at 2018-09-10T17:13:34Z
virgl: don't send a shader create with no data. (v2)
This fixes the situation where we'd send a shader with just the
header and no data.
piglit/glsl-max-varyings test was causing this to happen, and
the renderer fix was breaking it.
v2: drop fprintf
Fixes: a8987b88ff1d "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Erik Faye-Lund <erik.faye-***@collabora.com>
(cherry picked from commit 240af6149477beb06fdcfc4b0295921448c0fe47)
- - - - -
aeb8b006 by Marek Olšák at 2018-09-11T15:17:31Z
radeonsi: fix HTILE for NPOT textures with mipmapping on SI/CI
VI uses addrlib so it's unaffected.
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit a1b9a00f82db79e59e4a743d52bb62c998584690)
Conflicts resolved by Dylan
Conflicts:
src/gallium/drivers/radeonsi/si_texture.c
- - - - -
517c2f1e by Marek Olšák at 2018-09-11T15:18:16Z
r600: fix HTILE for NPOT textures with mipmapping
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit da72b6296cfa5c5fa92d840d8a69c55df19d13f5)
- - - - -
09196d4b by Marek Olšák at 2018-09-11T15:18:28Z
radeonsi: fix printing a BO list into ddebug reports
important for debugging
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit 662db03577377cd0acca279ca482ea8e9a4e1704)
- - - - -
3a23ba5a by Christopher Egert at 2018-09-11T15:19:02Z
radeon: fix ColorMask
Since commit af3685d14936844f79e6f372b4b258e29375f21b various OpenGL applications regressed
on the classic mesa radeon driver.
Signed-off-by: Christopher Egert <***@gmail.com>
CC: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Signed-off-by: Marek Olšák <***@amd.com>
(cherry picked from commit 51995f69204e8a751cb1a3e502e013acf7fff031)
- - - - -
eb6abe40 by Dylan Baker at 2018-09-11T15:19:39Z
cherry-ignore: Add more 18.2 patches
- - - - -
e89a4589 by Michel Dänzer at 2018-09-12T15:46:26Z
loader/dri3: Only wait for back buffer fences in dri3_get_buffer
We don't need to wait before drawing to the fake front buffer, as front
buffer rendering by definition is allowed to produce artifacts.
Fixes hangs in some cases when re-using the fake front buffer, due to it
still being busy (i.e. in use for presentation).
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/106404
Bugzilla: https://bugs.freedesktop.org/107757
Tested-by: Olivier Fourdan <***@redhat.com>
Reviewed-by: Thomas Hellstrom <***@vmware.com>
(cherry picked from commit aefac10fecc9ec70feb5923ce3200902f67182ba)
- - - - -
1816f280 by Erik Faye-Lund at 2018-09-12T15:46:47Z
winsys/virgl: avoid unintended behavior
If we end up never taking the loop that writes ret, we can end up with
an uninitialized value, and if we're *really* unlucky, that value can
be -1, causing us to go down an error-path instead of a success path.
This was obviously not intended, so let's just initialize this to zero.
Noticed by Valgrind:
Conditional jump or move depends on uninitialised value(s)
at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348)
by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170)
by 0xBA605AC: virgl_resource_create (virgl_resource.c:60)
by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344)
by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390)
by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136)
by 0xBCFCC6E: st_create_context_priv (st_context.c:414)
by 0xBCFD3CD: st_create_context (st_context.c:590)
by 0xBBB30CA: st_api_create_context (st_manager.c:896)
by 0xB981E76: dri_create_context (dri_context.c:155)
by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473)
by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309)
by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78)
Fixes: a8987b88ff1 ("virgl: add driver for virtio-gpu 3D (v2)")
Signed-off-by: Erik Faye-Lund <erik.faye-***@collabora.com>
(cherry picked from commit eaa718588ee97241cdbfea0b49bc30d93a99667c)
- - - - -
33f5a21c by Dylan Baker at 2018-09-14T16:09:14Z
cherry-ignore: add 18.2 patchs
- - - - -
cf54d5f4 by Erik Faye-Lund at 2018-09-14T16:09:32Z
virgl: adjust strides when mapping temp-resources
When we're mapping temp-resources, we clip the resource to the
transfer-box, which means the stride might not be correct any more.
So let's update the stride from the temp-resource, and recompute the
layer-stride.
This fixes crashes when running dEQP with --deqp-gl-config-name=rgba8888d24s8ms4
Signed-off-by: Erik Faye-Lund <erik.faye-***@collabora.com>
Fixes: a8987b88ff1 "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Dave Airlie <***@redhat.com>
(cherry picked from commit fa5e9f1f73f64ac089f8efd5b101a77d06d22fcd)
- - - - -
649aff1a by Pierre Moreau at 2018-09-14T16:12:08Z
nvir: Always split 64-bit IMAD/IMUL operations
Those operations do not map to actual hardware instructions, therefore
those should always be lowered to 32-bit instructions.
Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations"
Signed-off-by: Pierre Moreau <***@free.fr>
Reviewed-by: Karol Herbst <***@redhat.com>
Signed-off-by: Karol Herbst <***@redhat.com>
(cherry picked from commit 21b92b3464193a203e069f50c21ebec146ae0215)
Conflicts resolved by Dylan
Conflicts:
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
- - - - -
3a34419c by Josh Pieper at 2018-09-17T20:31:51Z
st/mesa: Validate the result of pipe_transfer_map in make_texture (v2)
When using Freecad, I was getting intermittent segfaults inside of
mesa. I traced it down to this path in st_cb_drawpixels.c where the
result of pipe_transfer_map wasn't being checked. In my case, it was
returning NULL because nouveau_bo_new returned ENOENT. I'm by no
means a mesa developer, but this patch solves the problem for me and
seems reasonable enough.
v2: Marek - also unmap the PBO and release the texture, and call
the make_texture function sooner for less cleanup
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 936e0dcd619bc092b9869b4be2e1b20c3631131f)
- - - - -
da9fc5c1 by Bas Nieuwenhuizen at 2018-09-17T20:32:39Z
radv: Use build ID if available for cache UUID.
To get an useful UUID for systems that have a non-useful mtime
for the binaries.
I started using SHA1 to ensure we get reasonable mixing in the
various possibilities and the various build id lengths.
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Timothy Arceri <***@itsqueeze.com>
(cherry picked from commit d17443a459383fdd7018fa879134f05b5daff1e1)
- - - - -
3366da58 by Kenneth Feng at 2018-09-18T23:31:32Z
amd: Add Picasso device id
No changes here compared to Raven.
Reviewed-by: Marek Olšák <***@amd.com>
Reviewed-by: Huang Rui <***@amd.com>
Signed-off-by: Kenneth Feng <***@amd.com>
Signed-off-by: Huang Rui <***@amd.com>
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 4490fce16631fbc098f2fcf3f2c4b73f32a974a5)
- - - - -
551b07ab by Jason Ekstrand at 2018-09-18T23:31:51Z
anv/query: Write both dwords in emit_zero_queries
Each query slot is a uint64_t and we were only zeroing half of it.
Fixes: 7ec6e4e68980 "anv/query: implement multiview interactions"
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit 07e214f1ce263edcecb674d6d2f48569fa1d12ed)
- - - - -
e402a7ef by Dylan Baker at 2018-09-18T23:37:34Z
cherry-ignore: add a patch that was reverted on master
- - - - -
b38445b2 by Bas Nieuwenhuizen at 2018-09-18T23:40:19Z
radv: Only allow 16 user SGPRs for compute on GFX9+.
Apparently for compute there are only 16 instead of the 32 for the
graphics path.
Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit 0dd8189f159258ad8684036b0d696dbb58a268ca)
Conflicts Resolved by Dylan
Conflicts:
src/amd/vulkan/radv_nir_to_llvm.c
- - - - -
59c708ff by Bas Nieuwenhuizen at 2018-09-18T23:43:55Z
radv: Set the user SGPR MSB for Vega.
Otherwise using 32 user SGPRs would be broken.
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit d97c892584cd0641913de2635689c6b59c98816e)
Conflicts resolved by Dylan
Conflicts:
src/amd/vulkan/radv_shader.c
- - - - -
0be61a9f by Michal Srb at 2018-09-20T15:51:22Z
st/dri: don't set queryDmaBufFormats/queryDmaBufModifiers if the driver does not implement it
This is equivalent to commit a65db0ad1c3, but for dri_kms_init_screen. Without
this gbm_dri_is_format_supported always returns false.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104926
Fixes: e14fe41e0bf ("st/dri: implement createImageFromRenderbuffer(2)")
Reviewed-by: Emil Velikov <***@collabora.com>
Reviewed-by: Adam Jackson <***@redhat.com>
Tested-by: Adam Williamson <***@fedoraproject.org>
(cherry picked from commit 194bf0a2e01769f4b29df06febf27ce340c1cd68)
- - - - -
80d2139e by Mauro Rossi at 2018-09-20T20:29:39Z
android: broadcom/genxml: fix collision with intel/genxml header-gen macro
Backport to mesa 18.1
Fixes the following building error, happening when building both intel and broadcom:
Gen Header: libmesa_broadcom_genxml_32 <= v3d_packet_v21_pack.h
FAILED: out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h
/bin/bash -c "python external/mesa/src/broadcom/cle/gen_pack_header.py \
external/mesa/src/broadcom/cle/v3d_packet_v21.xml \
> out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h"
Traceback (most recent call last):
File "external/mesa/src/broadcom/cle/gen_pack_header.py", line 626, in <module>
p = Parser(sys.argv[2])
IndexError: list index out of range
header-gen macro is already defined by Intel genxml building rules
and the existing header-gen does not have the $(PRIVATE_VER) argument,
infact the bash command line logged in the building error is missing
exactly $(PRIVATE_VER) argument
Renaming the macro as pack-header-gen in src/broadcom/Android.genxml.mk
solves the building error, another possible way is to keep the gen rules
commands expanded and not use the macros.
Fixes: 7f80a9ff13 ("vc4: Introduce XML-based packet header generation like Intel's.")
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
9b850150 by Mauro Rossi at 2018-09-20T20:29:40Z
android: broadcom/cle: add gallium include path
Fixes the following building error:
In file included from external/mesa/src/broadcom/cle/v3d_decoder.c:38:
In file included from external/mesa/src/broadcom/cle/v3d_packet_helpers.h:29:
external/mesa/src/gallium/auxiliary/util/u_math.h:42:10:
fatal error: 'pipe/p_compiler.h' file not found
^~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-***@lists.freedesktop.org>
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
309945ec by Mauro Rossi at 2018-09-20T20:29:41Z
android: broadcom/cle: export the broadcom top level path headers
Fixes the following building error in vc4 build:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_render_cl.c:34:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_drv.h:27:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_simulator_validate.h:34:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_context.h:39:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_cl.h:56:
out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h:12:10:
fatal error: 'cle/v3d_packet_helpers.h' file not found
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-***@lists.freedesktop.org>
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
6819121e by Dylan Baker at 2018-09-20T20:30:54Z
cherry-ignore: one final update
- - - - -
a76c43fc by Bas Nieuwenhuizen at 2018-09-20T21:53:59Z
radv: Fix driver UUID SHA1 init.
Was missing the init, found by Emil.
Fixes: d17443a4593 "radv: Use build ID if available for cache UUID."
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Eric Engestrom <***@intel.com>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit 0a77e70d1040eb98253a172908785303c3abdbd5)
- - - - -
634f4f98 by Dylan Baker at 2018-09-21T16:02:55Z
Bump version to 18.1.9
- - - - -
f57f37f3 by Dylan Baker at 2018-09-24T15:43:25Z
docs: Add 18.1.9 release notes
- - - - -
f989b264 by Andreas Boll at 2018-10-10T14:09:49Z
Merge tag 'mesa-18.1.9' into debian-unstable
mesa-18.1.9
- - - - -
ca5e3971 by Andreas Boll at 2018-10-10T14:10:11Z
Bump changelog
- - - - -
861acd47 by Jan Vesely at 2018-10-10T14:11:08Z
clover: Add explicit virtual destructor to argument class
It is needed to destroy the v vector in scalar_argument
Fixes memory leaks on parameter set/bind.
v2: Drop redundant sclara_argument destructor
Signed-off-by: Jan Vesely <***@rutgers.edu>
Reviewed-by: Francisco Jerez <***@riseup.net>
(cherry picked from commit 2f1ad72ac17268989d4033e8e3f9460c68eae462)
- - - - -
c9e6fe5c by Andreas Boll at 2018-10-10T14:18:09Z
Document the cherry-pick in debian/changelog
- - - - -
27538291 by Andreas Boll at 2018-10-10T14:54:27Z
Upload to unstable.
- - - - -
30 changed files:
- VERSION
- bin/.cherry-ignore
- debian/changelog
- docs/relnotes/18.1.8.html
- + docs/relnotes/18.1.9.html
- include/pci_ids/radeonsi_pci_ids.h
- meson.build
- src/amd/vulkan/radv_device.c
- src/amd/vulkan/radv_nir_to_llvm.c
- src/amd/vulkan/radv_shader.c
- src/broadcom/Android.cle.mk
- src/broadcom/Android.genxml.mk
- src/compiler/glsl/glcpp/glcpp-lex.l
- src/compiler/glsl/glcpp/glcpp.h
- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
- src/gallium/drivers/r600/r600_texture.c
- src/gallium/drivers/radeonsi/si_gfx_cs.c
- src/gallium/drivers/radeonsi/si_texture.c
- src/gallium/drivers/virgl/virgl_encode.c
- src/gallium/drivers/virgl/virgl_texture.c
- src/gallium/state_trackers/clover/core/kernel.hpp
- src/gallium/state_trackers/dri/dri2.c
- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
- src/glx/apple/apple_glx_log.c
- src/intel/Makefile.vulkan.am
- src/intel/meson.build
- src/intel/vulkan/gen7_cmd_buffer.c
- src/intel/vulkan/genX_cmd_buffer.c
- src/intel/vulkan/genX_pipeline.c
- src/intel/vulkan/genX_query.c
The diff was not included because it is too large.
View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/compare/46432bd59428c15015d7228e56f6b69ed071454d...27538291f2e826f69efa2cbfcaa128a1e0a0401e
Commits:
ad478400 by Dylan Baker at 2018-09-07T17:10:13Z
docs/relnotes: Add sha256 sums for mesa 18.1.8
- - - - -
a985f18e by Marek Olšák at 2018-09-07T17:16:55Z
st/mesa: help fix stencil border color for GL_DEPTH_STENCIL textures
GL_STENCIL_INDEX uses GL_INTENSITY for the border color, which is nicer
to hardware that doesn't read the stencil border value from the X channel.
This fixes a bunch of dEQP tests on Vega & Raven.
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 725e8ad5590749ca2fa4bd89e1e8007fd20b114e)
- - - - -
2620eb8e by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: Add additional 18.2 patch
- - - - -
37fd6269 by Gert Wollny at 2018-09-07T17:16:55Z
winsys/virgl: correct resource and handle allocation (v2)
Fixes crash with
piglit/bin/map_buffer_range-invalidate CopyBufferSubData \
increment-offset -auto -fbo
* Resize the resource storage already when the count is equal to the
allocated size, fixes:
Invalid write of size 8
at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629)
by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd
at 0x4C31B25: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567)
* Also resize the space allocated for the handles, fixes:
Invalid write of size 4
at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631)
by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663)
by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776)
by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585)
by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940)
by 0x109A1E: upload (invalidate.c:169)
by 0x109C2F: piglit_display (invalidate.c:215)
by 0x4F80FBE: run_test (piglit_fbo_framework.c:52)
by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229)
by 0x10949D: main (invalidate.c:47)
Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd
at 0x4C2FB0F: malloc (
in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so)
by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572)
Fixes: 4b15b5e803e ("virgl: resize resource bo allocation if we need to.")
v2: - Use REALLOC macro and avoid memory leak when re-allocation fails
- add Fixes tag (both Emil Velikov)
- reorder commit message
Signed-off-by: Gert Wollny <***@collabora.com>
(cherry picked from commit 9b0e8d87233691c1f025002f1da89ed3f8f69583)
- - - - -
527813b2 by Dylan Baker at 2018-09-07T17:16:55Z
meson: Print a message about why a libdrm version was selected
We require a single version of libdrm for all of our libdrm
dependencies (core and driver), but the way this is structured can make
the error message less than helpful, as one driver might be the one
setting the libdrm requirement, while another might be the one that
generates the version failure.
This adds a simple message to the output announcing which libdrm module
set the version, which might be more helpful.
v2: - Use message suggested by Eric Engstrom
Fixes: c445b1d56f47922206de55e557444aadb62e11f6
("meson: Use the same version for all libdrm checks")
Reviewed-by: Eric Engestrom <***@intel.com>
(cherry picked from commit d25a27ec56dd9a722a3b6073ec0b6daa7993b0d7)
- - - - -
06579faa by Mathias Fröhlich at 2018-09-07T17:16:55Z
tnl: Fix green gun regression in xonotic.
Fix an other regression of
mesa: Make gl_vertex_array contain pointers to first order VAO members.
The regression showed up with drivers using the tnl module and
was reproducible using xonotic-glx -benchmark demos/the-big-keybench.dem.
Fixes: 64d2a204805
mesa: Make gl_vertex_array contain pointers to first order VAO members.
Tested-by: Ville Syrjälä <***@linux.intel.com>
Reviewed-by: Ian Romanick <***@intel.com>
Signed-off-by: Mathias Fröhlich <***@web.de>
(cherry picked from commit a6232b69321b465e9733a4b207088d923b75e714)
Conflicts resolved by Dylan
Conflicts:
src/mesa/tnl/t_split_copy.c
- - - - -
67cfeb16 by Timothy Arceri at 2018-09-07T17:16:55Z
glsl: fixer lexer for unreachable defines
If we have something like:
#ifdef NOT_DEFINED
#define A_MACRO(x) \
if (x)
#endif
The # on the #define is not skipped but the define itself is so
this then gets recognised as #if.
Until 28a3731e3f this didn't happen because we ended up in
<HASH>{NONSPACE} where BEGIN INITIAL was called stopping the
problem from happening.
This change makes sure we never call RETURN_TOKEN_NEVER_SKIP for
if/else/endif when processing a define.
Cc: Ian Romanick <***@freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
- - - - -
6f43390d by Jason Ekstrand at 2018-09-07T17:16:55Z
anv/pipeline: Only consider double elements which actually exist
The brw_vs_prog_data::double_inputs_read field comes directly from
shader_info::double_inputs which may contain inputs which are not
actually read. Instead of using it directly, AND it with inputs_read
which is only things which are read. Otherwise, we may end up
subtracting too many elements when computing elem_count.
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103241
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit 7b26741806c521279a1b83f2eae40a277d806626)
- - - - -
b5e03dec by Sergii Romantsov at 2018-09-07T17:16:55Z
intel: compiler option msse2 and mstackrealign
Seems in case of 32-bit library, usage of msse2 makes
some stack corruption or incorrect instructions.
Usage with mstackrealign fixes that case.
v2: Fixed meson.
v3: Definition of c_sse2_args moved on the top (L.Landwerlin).
Added mstackrealign for Android's mks where msee4.1 is used.
v4: Added for Vulkan also.
v5: Commit message correction.
CC: <mesa-***@lists.freedesktop.org>
Fixes: 6b05c080f202 (i965: Compile with -msse3)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779
Signed-off-by: Sergii Romantsov <***@globallogic.com>
Reviewed-by: Dylan Baker <***@pnwbakers.com>
Reviewed-by: Emil Velikov <***@collabora.com>
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit d709f127927cb0ad40d5bf4eaec33c3c27f7738a)
- - - - -
b14c2b46 by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: add another 18.2 patch
- - - - -
019ff6b4 by Andrii Simiklit at 2018-09-07T17:16:55Z
apple/glx/log: added missing va_end() after va_copy()
Each invocation of va_copy() must be matched by a
corresponding invocation of va_end()
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 51691f0767f6 "darwin: Use ASL for logging"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 267ed29288db478a47d180bd1370a4df60ddb3ef)
- - - - -
4a44ff8b by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: don't use the same 'va_list' instance twice
The first usage of the 'va_list' instance could change it.
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 570cacba7af165175ad40820c5e663db5b1c5066)
- - - - -
a17aed45 by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: don't ignore NULL returned from 'malloc'
We should exit from the function 'util_vasprintf'
with error code -1 for case where 'malloc'
returns NULL
Reviewed-by: Eric Engestrom <***@intel.com>
Fixes: 864148d69e1e "util: add util_vasprintf() for Windows (v2)"
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 65cfe698b0f4ba412198d212c14481a60c1b8389)
- - - - -
ea7df5b7 by Andrii Simiklit at 2018-09-07T17:16:55Z
mesa/util: add missing va_end() after va_copy()
MSDN:
"va_end must be called on each argument list that's initialized
with va_start or va_copy before the function returns."
Reviewed-by: Eric Engestrom <***@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107810
Fixes: c6267ebd6c8a "gallium/util: Stop bundling our snprintf implementation."
Signed-off-by: Andrii Simiklit <***@globallogic.com>
(cherry picked from commit 2930b76cfe1e13e84ac0d88f9c6d709a5a8d4c18)
- - - - -
99ecc5fc by Dylan Baker at 2018-09-07T17:16:55Z
cherry-ignore: Add patches that don't apply cleanly and are for developer tools
- - - - -
08e3909c by Jason Ekstrand at 2018-09-10T17:12:04Z
i965: Workaround the gen9 hw astc5x5 sampler bug
gen9 hardware has a bug in the sampler cache that can cause GPU hangs
whenever an texture with aux compression enabled is in the sampler cache
together with an ASTC5x5 texture. Because we can't control what the
client binds at any given time, we have two options: resolve the CCS or
decompresss the ASTC. Doing a CCS or HiZ resolve is far less drastic
and will likely have a smaller performance impact.
Cc: mesa-***@lists.freedesktop.org
Reviewed-by: Kristian H. Kristensen <***@google.com>
Tested-by: Tapani Pälli <***@intel.com>
Reviewed-by: Topi Pohjolainen <***@intel.com>
(cherry picked from commit f9e630e23dfa3de815026a08e7e767e2ed90da0b)
- - - - -
9f08ea8c by Jason Ekstrand at 2018-09-10T17:12:09Z
anv: Re-emit vertex buffers when the pipeline changes
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance
data step rate, and pitch come from the pipeline.
Cc: mesa-***@lists.freedesktop.org
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit c643c5e18d7c647afc6dcc450183b81a62a40998)
- - - - -
3bfed07f by Jason Ekstrand at 2018-09-10T17:12:20Z
anv: Disable the vertex cache when tessellating on SKL GT4
I have no idea if I'm correct about what's going wrong or if this is the
correct fix. However, in my multiple weeks of banging my head on this
hang, a VUE reference counting bug seems to match all the symptoms and
it definitely fixes the hang.
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107280
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit b08b4b2b25b201df2d667cf70d7f99475e5c7aec)
- - - - -
05985a64 by Jason Ekstrand at 2018-09-10T17:13:27Z
anv: Clamp scissors to the framebuffer boundary
The Vulkan 1.1.81 spec says:
"It is legal for offset.x + extent.width or offset.y + extent.height
to exceed the dimensions of the framebuffer - the scissor test still
applies as defined above. Rasterization does not produce fragments
outside of the framebuffer, so such fragments never have the scissor
test performed on them."
Elsewhere, the Vulkan 1.1.81 spec says:
"The application must ensure (using scissor if necessary) that all
rendering is contained within the render area, otherwise the pixels
outside of the render area become undefined and shader side effects
may occur for fragments outside the render area. The render area
must be contained within the framebuffer dimensions."
Unfortunately, there's some room for interpretation here as to what the
consequences are of having the render area set to exactly the
framebuffer dimensions and having a scissor that is larger than the
framebuffer. Given that GL and other APIs provide automatic clipping to
the framebuffer, it makes sense that applications would assume that
Vulkan does this as well. It costs us very little to play it safe and
just clamp client-provided scissors to the framebuffer dimensions.
Fortunately, the user is required to provide us with at least one
scissor so we don't need to handle the case where they don't.
Fixes: fb2a5ceb3264 "anv: Emit DRAWING_RECTANGLE once at driver..."
Reviewed-by: Kenneth Graunke <***@whitecape.org>
(cherry picked from commit 465e5a868cd58ca7c4ff7476e98231ffd4f3d2bf)
- - - - -
4670daa1 by Dave Airlie at 2018-09-10T17:13:34Z
virgl: don't send a shader create with no data. (v2)
This fixes the situation where we'd send a shader with just the
header and no data.
piglit/glsl-max-varyings test was causing this to happen, and
the renderer fix was breaking it.
v2: drop fprintf
Fixes: a8987b88ff1d "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Erik Faye-Lund <erik.faye-***@collabora.com>
(cherry picked from commit 240af6149477beb06fdcfc4b0295921448c0fe47)
- - - - -
aeb8b006 by Marek Olšák at 2018-09-11T15:17:31Z
radeonsi: fix HTILE for NPOT textures with mipmapping on SI/CI
VI uses addrlib so it's unaffected.
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit a1b9a00f82db79e59e4a743d52bb62c998584690)
Conflicts resolved by Dylan
Conflicts:
src/gallium/drivers/radeonsi/si_texture.c
- - - - -
517c2f1e by Marek Olšák at 2018-09-11T15:18:16Z
r600: fix HTILE for NPOT textures with mipmapping
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit da72b6296cfa5c5fa92d840d8a69c55df19d13f5)
- - - - -
09196d4b by Marek Olšák at 2018-09-11T15:18:28Z
radeonsi: fix printing a BO list into ddebug reports
important for debugging
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Tested-by: Dieter Nützel <***@nuetzel-hh.de>
(cherry picked from commit 662db03577377cd0acca279ca482ea8e9a4e1704)
- - - - -
3a23ba5a by Christopher Egert at 2018-09-11T15:19:02Z
radeon: fix ColorMask
Since commit af3685d14936844f79e6f372b4b258e29375f21b various OpenGL applications regressed
on the classic mesa radeon driver.
Signed-off-by: Christopher Egert <***@gmail.com>
CC: 18.1 18.2 <mesa-***@lists.freedesktop.org>
Signed-off-by: Marek Olšák <***@amd.com>
(cherry picked from commit 51995f69204e8a751cb1a3e502e013acf7fff031)
- - - - -
eb6abe40 by Dylan Baker at 2018-09-11T15:19:39Z
cherry-ignore: Add more 18.2 patches
- - - - -
e89a4589 by Michel Dänzer at 2018-09-12T15:46:26Z
loader/dri3: Only wait for back buffer fences in dri3_get_buffer
We don't need to wait before drawing to the fake front buffer, as front
buffer rendering by definition is allowed to produce artifacts.
Fixes hangs in some cases when re-using the fake front buffer, due to it
still being busy (i.e. in use for presentation).
Cc: mesa-***@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/106404
Bugzilla: https://bugs.freedesktop.org/107757
Tested-by: Olivier Fourdan <***@redhat.com>
Reviewed-by: Thomas Hellstrom <***@vmware.com>
(cherry picked from commit aefac10fecc9ec70feb5923ce3200902f67182ba)
- - - - -
1816f280 by Erik Faye-Lund at 2018-09-12T15:46:47Z
winsys/virgl: avoid unintended behavior
If we end up never taking the loop that writes ret, we can end up with
an uninitialized value, and if we're *really* unlucky, that value can
be -1, causing us to go down an error-path instead of a success path.
This was obviously not intended, so let's just initialize this to zero.
Noticed by Valgrind:
Conditional jump or move depends on uninitialised value(s)
at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348)
by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170)
by 0xBA605AC: virgl_resource_create (virgl_resource.c:60)
by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344)
by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390)
by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136)
by 0xBCFCC6E: st_create_context_priv (st_context.c:414)
by 0xBCFD3CD: st_create_context (st_context.c:590)
by 0xBBB30CA: st_api_create_context (st_manager.c:896)
by 0xB981E76: dri_create_context (dri_context.c:155)
by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473)
by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309)
by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78)
Fixes: a8987b88ff1 ("virgl: add driver for virtio-gpu 3D (v2)")
Signed-off-by: Erik Faye-Lund <erik.faye-***@collabora.com>
(cherry picked from commit eaa718588ee97241cdbfea0b49bc30d93a99667c)
- - - - -
33f5a21c by Dylan Baker at 2018-09-14T16:09:14Z
cherry-ignore: add 18.2 patchs
- - - - -
cf54d5f4 by Erik Faye-Lund at 2018-09-14T16:09:32Z
virgl: adjust strides when mapping temp-resources
When we're mapping temp-resources, we clip the resource to the
transfer-box, which means the stride might not be correct any more.
So let's update the stride from the temp-resource, and recompute the
layer-stride.
This fixes crashes when running dEQP with --deqp-gl-config-name=rgba8888d24s8ms4
Signed-off-by: Erik Faye-Lund <erik.faye-***@collabora.com>
Fixes: a8987b88ff1 "virgl: add driver for virtio-gpu 3D (v2)"
Reviewed-by: Dave Airlie <***@redhat.com>
(cherry picked from commit fa5e9f1f73f64ac089f8efd5b101a77d06d22fcd)
- - - - -
649aff1a by Pierre Moreau at 2018-09-14T16:12:08Z
nvir: Always split 64-bit IMAD/IMUL operations
Those operations do not map to actual hardware instructions, therefore
those should always be lowered to 32-bit instructions.
Fixes: 009c54aa7af "nv50/ir: Split 64-bit integer MAD/MUL operations"
Signed-off-by: Pierre Moreau <***@free.fr>
Reviewed-by: Karol Herbst <***@redhat.com>
Signed-off-by: Karol Herbst <***@redhat.com>
(cherry picked from commit 21b92b3464193a203e069f50c21ebec146ae0215)
Conflicts resolved by Dylan
Conflicts:
src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
- - - - -
3a34419c by Josh Pieper at 2018-09-17T20:31:51Z
st/mesa: Validate the result of pipe_transfer_map in make_texture (v2)
When using Freecad, I was getting intermittent segfaults inside of
mesa. I traced it down to this path in st_cb_drawpixels.c where the
result of pipe_transfer_map wasn't being checked. In my case, it was
returning NULL because nouveau_bo_new returned ENOENT. I'm by no
means a mesa developer, but this patch solves the problem for me and
seems reasonable enough.
v2: Marek - also unmap the PBO and release the texture, and call
the make_texture function sooner for less cleanup
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 936e0dcd619bc092b9869b4be2e1b20c3631131f)
- - - - -
da9fc5c1 by Bas Nieuwenhuizen at 2018-09-17T20:32:39Z
radv: Use build ID if available for cache UUID.
To get an useful UUID for systems that have a non-useful mtime
for the binaries.
I started using SHA1 to ensure we get reasonable mixing in the
various possibilities and the various build id lengths.
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Timothy Arceri <***@itsqueeze.com>
(cherry picked from commit d17443a459383fdd7018fa879134f05b5daff1e1)
- - - - -
3366da58 by Kenneth Feng at 2018-09-18T23:31:32Z
amd: Add Picasso device id
No changes here compared to Raven.
Reviewed-by: Marek Olšák <***@amd.com>
Reviewed-by: Huang Rui <***@amd.com>
Signed-off-by: Kenneth Feng <***@amd.com>
Signed-off-by: Huang Rui <***@amd.com>
Cc: 18.1 18.2 <mesa-***@lists.freedesktop.org>
(cherry picked from commit 4490fce16631fbc098f2fcf3f2c4b73f32a974a5)
- - - - -
551b07ab by Jason Ekstrand at 2018-09-18T23:31:51Z
anv/query: Write both dwords in emit_zero_queries
Each query slot is a uint64_t and we were only zeroing half of it.
Fixes: 7ec6e4e68980 "anv/query: implement multiview interactions"
Reviewed-by: Lionel Landwerlin <***@intel.com>
(cherry picked from commit 07e214f1ce263edcecb674d6d2f48569fa1d12ed)
- - - - -
e402a7ef by Dylan Baker at 2018-09-18T23:37:34Z
cherry-ignore: add a patch that was reverted on master
- - - - -
b38445b2 by Bas Nieuwenhuizen at 2018-09-18T23:40:19Z
radv: Only allow 16 user SGPRs for compute on GFX9+.
Apparently for compute there are only 16 instead of the 32 for the
graphics path.
Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit 0dd8189f159258ad8684036b0d696dbb58a268ca)
Conflicts Resolved by Dylan
Conflicts:
src/amd/vulkan/radv_nir_to_llvm.c
- - - - -
59c708ff by Bas Nieuwenhuizen at 2018-09-18T23:43:55Z
radv: Set the user SGPR MSB for Vega.
Otherwise using 32 user SGPRs would be broken.
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit d97c892584cd0641913de2635689c6b59c98816e)
Conflicts resolved by Dylan
Conflicts:
src/amd/vulkan/radv_shader.c
- - - - -
0be61a9f by Michal Srb at 2018-09-20T15:51:22Z
st/dri: don't set queryDmaBufFormats/queryDmaBufModifiers if the driver does not implement it
This is equivalent to commit a65db0ad1c3, but for dri_kms_init_screen. Without
this gbm_dri_is_format_supported always returns false.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104926
Fixes: e14fe41e0bf ("st/dri: implement createImageFromRenderbuffer(2)")
Reviewed-by: Emil Velikov <***@collabora.com>
Reviewed-by: Adam Jackson <***@redhat.com>
Tested-by: Adam Williamson <***@fedoraproject.org>
(cherry picked from commit 194bf0a2e01769f4b29df06febf27ce340c1cd68)
- - - - -
80d2139e by Mauro Rossi at 2018-09-20T20:29:39Z
android: broadcom/genxml: fix collision with intel/genxml header-gen macro
Backport to mesa 18.1
Fixes the following building error, happening when building both intel and broadcom:
Gen Header: libmesa_broadcom_genxml_32 <= v3d_packet_v21_pack.h
FAILED: out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h
/bin/bash -c "python external/mesa/src/broadcom/cle/gen_pack_header.py \
external/mesa/src/broadcom/cle/v3d_packet_v21.xml \
> out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h"
Traceback (most recent call last):
File "external/mesa/src/broadcom/cle/gen_pack_header.py", line 626, in <module>
p = Parser(sys.argv[2])
IndexError: list index out of range
header-gen macro is already defined by Intel genxml building rules
and the existing header-gen does not have the $(PRIVATE_VER) argument,
infact the bash command line logged in the building error is missing
exactly $(PRIVATE_VER) argument
Renaming the macro as pack-header-gen in src/broadcom/Android.genxml.mk
solves the building error, another possible way is to keep the gen rules
commands expanded and not use the macros.
Fixes: 7f80a9ff13 ("vc4: Introduce XML-based packet header generation like Intel's.")
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
9b850150 by Mauro Rossi at 2018-09-20T20:29:40Z
android: broadcom/cle: add gallium include path
Fixes the following building error:
In file included from external/mesa/src/broadcom/cle/v3d_decoder.c:38:
In file included from external/mesa/src/broadcom/cle/v3d_packet_helpers.h:29:
external/mesa/src/gallium/auxiliary/util/u_math.h:42:10:
fatal error: 'pipe/p_compiler.h' file not found
^~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-***@lists.freedesktop.org>
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
309945ec by Mauro Rossi at 2018-09-20T20:29:41Z
android: broadcom/cle: export the broadcom top level path headers
Fixes the following building error in vc4 build:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_render_cl.c:34:
In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_drv.h:27:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_simulator_validate.h:34:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_context.h:39:
In file included from external/mesa/src/gallium/drivers/vc4/vc4_cl.h:56:
out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h:12:10:
fatal error: 'cle/v3d_packet_helpers.h' file not found
^~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Fixes: 5b102160ae ("broadcom/genxml: Introduce a V3D packet/struct decoder.")
Cc: "18.2" <mesa-***@lists.freedesktop.org>
Acked-by: Eric Anholt <***@anholt.net>
Reviewed-by: Emil Velikov <***@collabora.com>
Signed-off-by: Mauro Rossi <***@gmail.com>
- - - - -
6819121e by Dylan Baker at 2018-09-20T20:30:54Z
cherry-ignore: one final update
- - - - -
a76c43fc by Bas Nieuwenhuizen at 2018-09-20T21:53:59Z
radv: Fix driver UUID SHA1 init.
Was missing the init, found by Emil.
Fixes: d17443a4593 "radv: Use build ID if available for cache UUID."
CC: <mesa-***@lists.freedesktop.org>
Reviewed-by: Eric Engestrom <***@intel.com>
Reviewed-by: Samuel Pitoiset <***@gmail.com>
(cherry picked from commit 0a77e70d1040eb98253a172908785303c3abdbd5)
- - - - -
634f4f98 by Dylan Baker at 2018-09-21T16:02:55Z
Bump version to 18.1.9
- - - - -
f57f37f3 by Dylan Baker at 2018-09-24T15:43:25Z
docs: Add 18.1.9 release notes
- - - - -
f989b264 by Andreas Boll at 2018-10-10T14:09:49Z
Merge tag 'mesa-18.1.9' into debian-unstable
mesa-18.1.9
- - - - -
ca5e3971 by Andreas Boll at 2018-10-10T14:10:11Z
Bump changelog
- - - - -
861acd47 by Jan Vesely at 2018-10-10T14:11:08Z
clover: Add explicit virtual destructor to argument class
It is needed to destroy the v vector in scalar_argument
Fixes memory leaks on parameter set/bind.
v2: Drop redundant sclara_argument destructor
Signed-off-by: Jan Vesely <***@rutgers.edu>
Reviewed-by: Francisco Jerez <***@riseup.net>
(cherry picked from commit 2f1ad72ac17268989d4033e8e3f9460c68eae462)
- - - - -
c9e6fe5c by Andreas Boll at 2018-10-10T14:18:09Z
Document the cherry-pick in debian/changelog
- - - - -
27538291 by Andreas Boll at 2018-10-10T14:54:27Z
Upload to unstable.
- - - - -
30 changed files:
- VERSION
- bin/.cherry-ignore
- debian/changelog
- docs/relnotes/18.1.8.html
- + docs/relnotes/18.1.9.html
- include/pci_ids/radeonsi_pci_ids.h
- meson.build
- src/amd/vulkan/radv_device.c
- src/amd/vulkan/radv_nir_to_llvm.c
- src/amd/vulkan/radv_shader.c
- src/broadcom/Android.cle.mk
- src/broadcom/Android.genxml.mk
- src/compiler/glsl/glcpp/glcpp-lex.l
- src/compiler/glsl/glcpp/glcpp.h
- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp
- src/gallium/drivers/r600/r600_texture.c
- src/gallium/drivers/radeonsi/si_gfx_cs.c
- src/gallium/drivers/radeonsi/si_texture.c
- src/gallium/drivers/virgl/virgl_encode.c
- src/gallium/drivers/virgl/virgl_texture.c
- src/gallium/state_trackers/clover/core/kernel.hpp
- src/gallium/state_trackers/dri/dri2.c
- src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
- src/glx/apple/apple_glx_log.c
- src/intel/Makefile.vulkan.am
- src/intel/meson.build
- src/intel/vulkan/gen7_cmd_buffer.c
- src/intel/vulkan/genX_cmd_buffer.c
- src/intel/vulkan/genX_pipeline.c
- src/intel/vulkan/genX_query.c
The diff was not included because it is too large.
View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/compare/46432bd59428c15015d7228e56f6b69ed071454d...27538291f2e826f69efa2cbfcaa128a1e0a0401e
--
View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/compare/46432bd59428c15015d7228e56f6b69ed071454d...27538291f2e826f69efa2cbfcaa128a1e0a0401e
You're receiving this email because of your account on salsa.debian.org.
View it on GitLab: https://salsa.debian.org/xorg-team/lib/mesa/compare/46432bd59428c15015d7228e56f6b69ed071454d...27538291f2e826f69efa2cbfcaa128a1e0a0401e
You're receiving this email because of your account on salsa.debian.org.