Bug#870836: /usr/bin/imake: imake generated makefile use deprecated -D_BSD_SOURCE and -D_SVID_SOURCE

[Rémi Vanicat]

Package: xutils-dev
Version: 1:7.7+5+b1
Severity: minor
File: /usr/bin/imake

Dear Maintainer,

While recompiling xdu, It generate the following error:

In file included from /usr/include/x86_64-linux-gnu/sys/types.h:25:0,
from /usr/include/X11/Xlib.h:38,
from /usr/include/X11/Intrinsic.h:53,
from xwin.c:22:
/usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
# warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
^~~~~~~

imake and xmkmf should stop using those define, and user -D_DEFAULT_SOURCE instead.

Thanks.

-- System Information:
Debian Release: 9.1
APT prefers oldstable-updates
APT policy: (500, 'oldstable-updates'), (500, 'stable'), (500, 'oldstable'), (155, 'testing'), (150, 'unstable'), (120, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages xutils-dev depends on:
ii cpp 4:6.3.0-4
ii libc6 2.24-12

xutils-dev recommends no packages.

xutils-dev suggests no packages.

-- no debconf information

[Teemu Ikonen]

Hi,

The attached patch against the xutils-dev git repo at salsa fixes
this for me. Note that there are also other definitions of
-D_BSD_SOURCE and -D_SVID_SOURCE in the sources, but they
probably do not affect Debian.

Best,
Teemu

[Bart Massey]

Hilariously, I just ran into this today when building a program I wrote in
1987. Thanks huge to Teemu for working out the patch; I have verified that
it works for me. It would be great if this could be packaged.